Abandon workitem if processing workitem failed #467
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the error handling and logging for background task processing in the gRPC worker, ensuring that when an error occurs, the system properly abandons the relevant work item and logs the process for orchestrator, activity, and entity work items. It also introduces comprehensive tests to verify the new logging behavior.
Enhanced error handling and logging:
RunBackgroundTaskinGrpcDurableTaskWorker.Processorto explicitly abandon orchestrator, activity, and both versions of entity work items when an error occurs, with detailed logging for each step. Throws an exception if the work item type is unknown.Logs.csfor "abandoning" and "abandoned" states for orchestrator, activity, and entity work items, each with distinct event IDs and message formats.Testing improvements:
RunBackgroundTaskLoggingTeststhat verifies the correct logging and abandonment behavior for orchestrator, activity, and both versions of entity work items when errors are encountered during background task processing.